Skip to content

[PWGDQ] Muon streaming improvement - #17519

Merged
mcoquet642 merged 2 commits into
AliceO2Group:masterfrom
lucamicheletti93:myDevStreamImprovement
Aug 21, 2026
Merged

[PWGDQ] Muon streaming improvement#17519
mcoquet642 merged 2 commits into
AliceO2Group:masterfrom
lucamicheletti93:myDevStreamImprovement

Conversation

@lucamicheletti93

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 74 errors, ⚠️ 253 warnings, 🔕 91 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9131f16 at 2026-08-20 00:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 0 warnings.'
Found 10 errors and 0 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/dad76afa46c31a4ab9c200a0ee85916d1a4ef937/O2Physics-code-check/errors.txt
PWGDQ/Core/CutsLibrary.cxx:7546:33: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7576:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7583:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7594:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7949:21: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7993:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:8024:10: error: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.h:122:23: error: function 'o2::aod::dqcuts::ParseJSONAnalysisCompositeCut' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.h:152:37: error: function 'o2::aod::dqmlcuts::makeLabeledCutsMl' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGDQ/TableProducer/tableMaker_withAssoc.cxx:1561:62: error: use designated initializer list to initialize 'EMCalMatch' [modernize-use-designated-initializers,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

} else if (bcEvSel.has_zdc()) {
auto bc_zdc = bcEvSel.zdc();
outTables.zdc(bc_zdc.energyCommonZNA(), bc_zdc.energyCommonZNC(), bc_zdc.energyCommonZPA(), bc_zdc.energyCommonZPC(),
outTables.zdc(VarManager::fgValues[VarManager::kEnergyCommonZNA], VarManager::fgValues[VarManager::kEnergyCommonZNC], VarManager::fgValues[VarManager::kEnergyCommonZPA], VarManager::fgValues[VarManager::kEnergyCommonZPC],

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because otherwise there is no protection on the values and they can be inf. In the varManager this is properly taken into account

@mcoquet642
mcoquet642 merged commit 883e58f into AliceO2Group:master Aug 21, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants